Skip to content

ci: add race, coverage, lint, govulncheck and tidy gates - #5

Merged
mattmattox merged 3 commits into
mainfrom
claude/ci-quality-gates-db4cd7
Oct 24, 2026
Merged

mattmattox merged 3 commits into
mainfrom
claude/ci-quality-gates-db4cd7

Conversation

@mattmattox

@mattmattox mattmattox commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Adds release CI gates: -race unit tests with a coverage job summary, golangci-lint v2.15.0, govulncheck v1.9.0, a go mod tidy check, SHA-pinned actions, and a read-only default token.

  • CI now installs the latest Go 1.26 patch and fails if go.mod moves to another minor. go-version-file installed 1.26.0, where govulncheck reports 2 reachable stdlib vulns (GO-2026-4971, GO-2026-4602).
  • No data races. Unit coverage is 53.1%.
  • errcheck is off because it has 447 findings. QF1008 is off (36 style hints).
  • Excluded as of 2026-10-24, because open PRs own this code: main.go SA1019 ×2, goclusterfs/fs.go unused ×2, extent_test.go SA4006 ×2, fsck/phase7_snapshots.go SA9003, dir_test.go deprecated Alloc ×14.
  • .gitignore had unanchored goclusterfs, fsck and mount lines. They hid new files in internal/goclusterfs, internal/fsck, cmd/fsck and cmd/mount.
  • Docker job:
    • The orchestrator wait goes from 600s to 1200s, the step limit from 12 to 22 min, and the job limit from 15 to 30 min. The test step took 446–496s on the last four green runs, up to 83% of the old budget. PR chore: add Apache-2.0 license #4 run 40077489458 ran past it during "Stress Random Failures", and the timeout handler's placeholder TestSetup failure turned the JUnit check red. This PR changes no test code.
    • checks: write on this job lets the JUnit report create its check run. Without it, the action logs "Resource not accessible by integration" on every run, including green ones.
    • Flake seen on this PR (run 40079479730, attempt 1): "Broadcast Bidirectional" failed with Node 1 cannot read file_a. Got 'fro', a short or stale cross-node read. The parent commit passed the same suite, and this PR's Go changes don't change behavior. In that run the suite took about 697s, so the old 600s budget would also have cut it off.

🤖 Generated with Claude Code

mattmattox and others added 3 commits October 24, 2026 03:46
Replace deprecated os.SEEK_* with io.Seek*, drop dead code (unused
writeRecord, batchSyncInFlight, mock inode table, empty branches,
ineffective assignments) and apply two loop/switch simplifications.
No behavior change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Unit tests run with -race and print coverage to the job summary.
- golangci-lint v2.15.0 and govulncheck v1.9.0 are pinned; make lint
  and make vuln run the same versions and config as CI.
- CI installs the latest Go 1.26 patch and checks it matches go.mod.
  Go 1.26.0, which go-version-file picked, has two stdlib vulns that
  govulncheck reports as reachable.
- Pin all actions to commit SHAs and default the token to read-only;
  only the Docker job gets checks: write for the JUnit report.
- Add build-fsck to make build, drop the legacy GoClusterFS binary
  from clean, and anchor .gitignore entries so they stop hiding new
  files in internal/goclusterfs, internal/fsck, cmd/fsck and cmd/mount.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test step took 446-496s on the last four green runs, up to 83% of
the 600s orchestrator wait, and PR #4 run 40077489458 ran past it
during "Stress Random Failures". Raise the wait to 1200s and the step
and job limits to match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit 31c415b into main Oct 24, 2026
6 of 7 checks passed
mattmattox added a commit that referenced this pull request Oct 24, 2026
…rnal fixes

Cover PRs #5, #6, #7 and #10, which merged to main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mattmattox added a commit that referenced this pull request Oct 24, 2026
…elog, and templates (#9)

* docs: add security policy, contributing guide, code of conduct, changelog, and templates

Adds the community files GitHub expects for a public release:
SECURITY.md (GitHub private vulnerability reporting, main only),
CONTRIBUTING.md, CODE_OF_CONDUCT.md (Contributor Covenant 2.1),
CHANGELOG.md with an Unreleased section, issue templates, and a
pull request template.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: correct build, CI, and changelog claims in community files

Write CONTRIBUTING against main after the CI gates PR: make build also
builds goclusterfs-fsck, and CI adds golangci-lint, govulncheck, a
go mod tidy check, and race/coverage unit tests.

In the changelog, mark SFB, snapshots/clones, and fsck as experimental
with their known issues, say file writes skip the distributed locks,
and narrow the concurrency fix to create/mkdir lock ordering.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changelog): add upgrade notes for mixed-version clusters

Older binaries zero an inode's generations on free and its extent-tree
generation on rewrite, so all nodes must be upgraded together.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changelog): add CI gates, prototype removal, stale-inode and journal fixes

Cover PRs #5, #6, #7 and #10, which merged to main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant