Repository navigation
ci: add race, coverage, lint, govulncheck and tidy gates - #5
Merged
Merged
Conversation
Replace deprecated os.SEEK_* with io.Seek*, drop dead code (unused writeRecord, batchSyncInFlight, mock inode table, empty branches, ineffective assignments) and apply two loop/switch simplifications. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Unit tests run with -race and print coverage to the job summary. - golangci-lint v2.15.0 and govulncheck v1.9.0 are pinned; make lint and make vuln run the same versions and config as CI. - CI installs the latest Go 1.26 patch and checks it matches go.mod. Go 1.26.0, which go-version-file picked, has two stdlib vulns that govulncheck reports as reachable. - Pin all actions to commit SHAs and default the token to read-only; only the Docker job gets checks: write for the JUnit report. - Add build-fsck to make build, drop the legacy GoClusterFS binary from clean, and anchor .gitignore entries so they stop hiding new files in internal/goclusterfs, internal/fsck, cmd/fsck and cmd/mount. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test step took 446-496s on the last four green runs, up to 83% of the 600s orchestrator wait, and PR #4 run 40077489458 ran past it during "Stress Random Failures". Raise the wait to 1200s and the step and job limits to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 24, 2026
mattmattox
added a commit
that referenced
this pull request
Oct 24, 2026
mattmattox
added a commit
that referenced
this pull request
Oct 24, 2026
…elog, and templates (#9) * docs: add security policy, contributing guide, code of conduct, changelog, and templates Adds the community files GitHub expects for a public release: SECURITY.md (GitHub private vulnerability reporting, main only), CONTRIBUTING.md, CODE_OF_CONDUCT.md (Contributor Covenant 2.1), CHANGELOG.md with an Unreleased section, issue templates, and a pull request template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: correct build, CI, and changelog claims in community files Write CONTRIBUTING against main after the CI gates PR: make build also builds goclusterfs-fsck, and CI adds golangci-lint, govulncheck, a go mod tidy check, and race/coverage unit tests. In the changelog, mark SFB, snapshots/clones, and fsck as experimental with their known issues, say file writes skip the distributed locks, and narrow the concurrency fix to create/mkdir lock ordering. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(changelog): add upgrade notes for mixed-version clusters Older binaries zero an inode's generations on free and its extent-tree generation on rewrite, so all nodes must be upgraded together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(changelog): add CI gates, prototype removal, stale-inode and journal fixes Cover PRs #5, #6, #7 and #10, which merged to main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds release CI gates:
-raceunit tests with a coverage job summary, golangci-lint v2.15.0, govulncheck v1.9.0, ago mod tidycheck, SHA-pinned actions, and a read-only default token.go-version-fileinstalled 1.26.0, where govulncheck reports 2 reachable stdlib vulns (GO-2026-4971, GO-2026-4602).main.goSA1019 ×2,goclusterfs/fs.gounused ×2,extent_test.goSA4006 ×2,fsck/phase7_snapshots.goSA9003,dir_test.godeprecatedAlloc×14..gitignorehad unanchoredgoclusterfs,fsckandmountlines. They hid new files ininternal/goclusterfs,internal/fsck,cmd/fsckandcmd/mount.TestSetupfailure turned the JUnit check red. This PR changes no test code.checks: writeon this job lets the JUnit report create its check run. Without it, the action logs "Resource not accessible by integration" on every run, including green ones.Node 1 cannot read file_a. Got 'fro', a short or stale cross-node read. The parent commit passed the same suite, and this PR's Go changes don't change behavior. In that run the suite took about 697s, so the old 600s budget would also have cut it off.🤖 Generated with Claude Code